search

Farama-Foundation / Arcade-Learning-Environment

The Arcade Learning Environment (ALE) -- a platform for AI research.
GNU General Public License v2.0
2.12k stars 420 forks source link

Frameskip = 0 makes no sense #449

Closed BenedictWilkins closed 2 years ago

BenedictWilkins commented 2 years ago

When making a new environment with frameskip = 0 the environment state will remain at the initial state after any number of steps.

env = gym.make("ALE/SpaceInvaders-v5", frameskip=0)

I wasted some time on this, better to give an error -- i.e. assert frameskip > 0 I can't think of any situation when someone would want this behaviour.

JesseFarebro commented 2 years ago

Thanks for pointing this out. The ALE interface does account for this but the Gym interface manages frame skipping itself. I'll make sure to make this more clear in the upcoming release.

JesseFarebro commented 2 years ago

This is fixed in beb8d8ec6cdf5d11f079b6cd22003c39625ba04f.