search

Farama-Foundation / Arcade-Learning-Environment

The Arcade Learning Environment (ALE) -- a platform for AI research.
https://ale.farama.org/
GNU General Public License v2.0
2.14k stars 420 forks source link

SDL/SDL.h not found when compiling with cmake -DUSE_SDL=ON #45

Closed mgbellemare closed 9 years ago

mgbellemare commented 9 years ago

MacPorts installs SDL in /opt/local/include/SDL. CMake correctly finds the library, and adds

-I/opt/local/include/SDL

to the include path used to compile ALE. However, a number of files include "SDL/SDL.h" (rather than SDL), and so building with SDL enabled fails on my machine.

Suggested fix: directly include "SDL.h" and fix the include paths in makefile.mac/unix accordingly.

mhauskn commented 9 years ago

SGTM. Once you push this change, I'll test on my Brew installed SDL to make sure things are still working on my end.

mgbellemare commented 9 years ago

I've pushed the change. Let me know if it breaks anything on your side.

On 28/02/2015 21:39, Matthew Hausknecht wrote:

SGTM. Once you push this change, I'll test on my Brew installed SDL to make sure things are still working on my end.

— Reply to this email directly or view it on GitHub https://github.com/mgbellemare/Arcade-Learning-Environment/issues/45#issuecomment-76547472.

mhauskn commented 9 years ago

Everything works well on my side.