Farama-Foundation / Arcade-Learning-Environment

The Arcade Learning Environment (ALE) -- a platform for AI research.
GNU General Public License v2.0
2.12k stars 420 forks source link

Seeding mechanism breaks in DEBUG builds #468

Open dreavjr opened 2 years ago

dreavjr commented 2 years ago

In environment.py, in AtariEnv.seed, the seed is converted to a signed integer, with the expectation that it will be reconverted into an unsigned integer inside stella_environment.

That only works in Release builds. In Debug builds, an assertion aborts execution when seed <= 0. That makes Debug builds unusable for development with Python.

JesseFarebro commented 1 year ago

Hi @dreavjr,

Good catch, this is annoying on debug builds. I'll circle back to this and hopefully fix it for the next release. Thanks!