Farama-Foundation / Arcade-Learning-Environment

The Arcade Learning Environment (ALE) -- a platform for AI research.
GNU General Public License v2.0
2.12k stars 420 forks source link

[BUG] Installation of python 3.10 manylinux wheels on PyPI fail on some machines #469

Closed vmoens closed 1 year ago

vmoens commented 1 year ago

Description of the problem

Installing the manylinux binaries ale_py-0.8.0-cp310-cp310-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl fails on some machines (e.g. see the CI for this commit on python 3.10: all jobs are failing because when installing ale-py, gym 0.26 is reverted to 0.25.2 as the 0.8.0 version of ale-py cannot be installed)

Proposed fix

Renaming the wheels to ale_py-0.8.0-cp310-cp310-manylinux_2_27_x86_64.manylinux2014_x86_64.whl seems to fix the issue.

JesseFarebro commented 1 year ago

Hi @vmoens, upgrading pip should fix this. A simple pip install -U pip will do the trick. Let me know if this still doesn't fix the issue for you.

vmoens commented 1 year ago

Thanks for this I tried upgrading pip and it still breaks

For ref: https://github.com/facebookresearch/rl/pull/403/commits/e9a6e3f449def3026f44f029301198028193d833

Tests: https://app.circleci.com/pipelines/github/facebookresearch/rl/2804/workflows/8ff53b69-ee8a-4e2b-b934-dab890dbf16e/jobs/52049

JesseFarebro commented 1 year ago

Duplicate of #478. This is fixed as of v0.8.1 🙌