cmake: patch to use system pybind11

Farama-Foundation / Arcade-Learning-Environment

The Arcade Learning Environment (ALE) -- a platform for AI research.

https://ale.farama.org/

GNU General Public License v2.0

2.14k stars 420 forks source link

cmake: patch to use system pybind11 #528

Closed chenrui333 closed 2 months ago

chenrui333 commented 4 months ago

patch to use system pybind11

relates to https://github.com/Homebrew/homebrew-core/pull/172212

pseudo-rnd-thoughts commented 4 months ago

Thanks for the PR, I'm a bit confused why the tests are failing. When building from scratch, the PR passes (CI / windows-latest py 3.8) however, when we build the wheels then install and run tests, this fails, not recognising the compiled part.

@chenrui333 Do you have any idea why this might be?

chenrui333 commented 4 months ago

I am seeing the same test failure on my homebrew build side too

chenrui333 commented 4 months ago

this also failed for me as well, https://github.com/chenrui333/Arcade-Learning-Environment/actions/runs/9179613891/job/25242161636

chenrui333 commented 4 months ago

@pseudo-rnd-thoughts does that answer your concern? (this PR works for the homebrew build, thanks!)

pseudo-rnd-thoughts commented 4 months ago

Errr, no as the CI is still failing so we can't merge.

chenrui333 commented 2 months ago

Thanks for the merge!