search

Farama-Foundation / Arcade-Learning-Environment

The Arcade Learning Environment (ALE) -- a platform for AI research.
https://ale.farama.org/
GNU General Public License v2.0
2.14k stars 420 forks source link

Change project src folder layout to use subfolder 'ale' #533

Closed maichmueller closed 1 month ago

maichmueller commented 3 months ago

Fixes #532

pseudo-rnd-thoughts commented 3 months ago

@maichmueller I think the issue is related to NumPy 2.0, if you limit the numpy<2.0 in pyproject.toml this will probably fix

maichmueller commented 3 months ago

Hi @pseudo-rnd-thoughts ,

Thanks for the hint! But this small numpy change now seems to cause the… vcpkg step to fail? I don’t quite understand the CI setup in how the steps interoperate; the changes in commits often don’t appear to me to correlate with the errors in the CI steps.

pseudo-rnd-thoughts commented 2 months ago

@maichmueller There were several issues with the CI that took a while to fix. Could you merge with main and see if vcpkg is fix

maichmueller commented 2 months ago

@pseudo-rnd-thoughts ,

thanks for those fixes! It seems the underlying CI issues have been resolved and all tests run successfully now. I am happy to bring this draft to full PR status then if you agree.

pseudo-rnd-thoughts commented 2 months ago

@maichmueller Thanks for sorting this, I'm not confident enough to confirm implementation @JesseFarebro Could you look at this? I believe you should have the c++ expertise, if not please say