search

Farama-Foundation / Arcade-Learning-Environment

The Arcade Learning Environment (ALE) -- a platform for AI research.
https://ale.farama.org/
GNU General Public License v2.0
2.18k stars 424 forks source link

Conan support #556

Open maichmueller opened 2 months ago

maichmueller commented 2 months ago

Hi,

I think Conan, the package manager, support in ALE would be useful.

There are 2 ways to achieve it from my understanding:

  1. the repo provides its own conanfile.py that configures the package and is maintained by the project itself.
  2. a conan-center recipe is added which configures the Conan package for ALE and is maintained at their index-repo.

Number 2 has the advantage that a consumer could add the repo with a simple line in their dependencies and it will be downloaded from the index-repo and added to their pojecct. I suppose 2 could make use of 1 as well but I haven't looked into this yet.

I could provide a solution for 1 though. Let me know if this is something you would like to be added.

pseudo-rnd-thoughts commented 2 months ago

If you would be happy to maintain number 2 then I would happy to that

maichmueller commented 2 months ago

hi @pseudo-rnd-thoughts , I looked into number 2 but I am afraid it is too much of a learning process right now for me to get done. Option 1 I know how to do and it is still valuable for conan users. Someone else (or I if i get around to it in the future) can then reference that work to start option 2 I guess. Option 1 woud mean adding 2 files conandata.yml and conanfile.py on the top level which people can use to build the ale package with conan create . --build=missing for their cache.

if you are happy with that i can add a PR.

pseudo-rnd-thoughts commented 2 months ago

That should be ok, I'm just worried about adding more features that needs to be maintained and won't be used much