Add pydocstyle to pre-commit, fix `get_keys_to_action` and environment frameskip

Farama-Foundation / Arcade-Learning-Environment

The Arcade Learning Environment (ALE) -- a platform for AI research.

https://ale.farama.org/

GNU General Public License v2.0

2.18k stars 424 forks source link

Closed pseudo-rnd-thoughts closed 2 months ago

pseudo-rnd-thoughts commented 2 months ago

This PR fixes several issues

Add pydocstyle to pre-commit
get_keys_to_action had None for no-op however for gymnasium.utils.play.play this is not allowed, therefore, this is updated to use e for no-op (https://github.com/Farama-Foundation/Arcade-Learning-Environment/issues/557)
The environment frameskip for v5 specified it was 5 however it was actually 4