Download ROMs using libtorrent

Farama-Foundation / AutoROM

A tool to automate installing Atari ROMs for the Arcade Learning Environment

MIT License

77 stars 21 forks source link

Download ROMs using libtorrent #16

Closed ycheng517 closed 1 year ago

ycheng517 commented 2 years ago

A couple of notes:

The torrent session uses the default connection settings, which exposes all network interfaces to port 6881. Hopefully this is good for general use cases.
The library outputs error alerts but they seem unimportant for download (i.e. one of the trackers is unreachable or timed out), so right now this PR does not check them

benblack769 commented 2 years ago

Code seems fine at first glance but it is hard to test because there is no magnet link.

benblack769 commented 2 years ago

Hmm. It actually passed tests.

ycheng517 commented 2 years ago

@benblack769 it looks like tests were passing because pip was preferring to install the package in pypi instead of the package locally built in the dist/ folder. I've now incremented the package version, so now pip should prefer the one in dist/ since it's newer, and so the tests should fail with RuntimeError: unsupported URL protocol which would be expected since we need a valid magnet URL.