The elements of "goal_cell" and "reset_cell" need to be inverted for the assertions since they represent the (i,j) cell in the maze map list of lists structure as specified in the docs.
The changes are made in both maze.py and maze_v4.py
Type of change
Please delete options that are not relevant.
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist:
[x] I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
Description
This PR fixes the comment in this previous PR https://github.com/Farama-Foundation/Gymnasium-Robotics/issues/163#issuecomment-1675839059
The elements of "goal_cell" and "reset_cell" need to be inverted for the assertions since they represent the
(i,j)
cell in the maze map list of lists structure as specified in the docs.The changes are made in both
maze.py
andmaze_v4.py
Type of change
Please delete options that are not relevant.
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)