Closed dtch1997 closed 7 months ago
Also, would like to point out that, maps.EMPTY_MAZE
is not used for neither PointMaze
nor AntMaze
https://github.com/Farama-Foundation/Gymnasium-Robotics/blob/f2754e19011a6ef329a40efc92dfa4bad81a22d3/gymnasium_robotics/envs/maze/maps.py#L19-L25
@dtch1997 please run the pre-commit
checks
Hi @Kallinteris-Andreas thanks for getting back to me on the PR.
I believe the failing pre-commit check is unrelated to my changes. Looking at the stack trace, the pyright failures appear to be due to this file:
/home/runner/work/Gymnasium-Robotics/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py
I do not know how to fix these issues.
Full stack trace from here:
typeshedPath /home/runner/work/Gymnasium-Robotics/Gymnasium-Robotics/typeshed is not a valid directory.
/home/runner/work/Gymnasium-Robotics/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py
/home/runner/work/Gymnasium-Robotics/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:277:24 - error: "mujoco" is possibly unbound (reportUnboundVariable)
/home/runner/work/Gymnasium-Robotics/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:278:23 - error: "mujoco_utils" is possibly unbound (reportUnboundVariable)
/home/runner/work/Gymnasium-Robotics/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:308:9 - error: "mujoco" is possibly unbound (reportUnboundVariable)
/home/runner/work/Gymnasium-Robotics/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:355:27 - error: "mujoco_py" is possibly unbound (reportUnboundVariable)
/home/runner/work/Gymnasium-Robotics/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:356:23 - error: "mujoco_py_utils" is possibly unbound (reportUnboundVariable)
@dtch1997 does it pass pre-commit
on your computer?
I am looking into the CI issues
@Kallinteris-Andreas No, I have the same error when running the linters locally.
$ pre-commit run --all-files
black....................................................................Passed
codespell................................................................Passed
flake8...................................................................Passed
isort....................................................................Passed
pyupgrade................................................................Passed
pyright..................................................................Failed
- hook id: pyright
- exit code: 1
typeshedPath /home/daniel/Documents/github/Gymnasium-Robotics/typeshed is not a valid directory.
/home/daniel/Documents/github/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py
/home/daniel/Documents/github/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:277:24 - error: "mujoco" is possibly unbound (reportUnboundVariable)
/home/daniel/Documents/github/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:278:23 - error: "mujoco_utils" is possibly unbound (reportUnboundVariable)
/home/daniel/Documents/github/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:308:9 - error: "mujoco" is possibly unbound (reportUnboundVariable)
/home/daniel/Documents/github/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:355:27 - error: "mujoco_py" is possibly unbound (reportUnboundVariable)
/home/daniel/Documents/github/Gymnasium-Robotics/gymnasium_robotics/envs/robot_env.py:356:23 - error: "mujoco_py_utils" is possibly unbound (reportUnboundVariable)
5 errors, 0 warnings, 0 informations
Description
Registers the
PointMaze_Open_Diverse_GR
environment.Fixes #194
Type of change
Please delete options that are not relevant.
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)