Farama-Foundation / Minigrid

Simple and easily configurable grid world environments for reinforcement learning
https://minigrid.farama.org/
Other
2.13k stars 610 forks source link

[Bug Report] README seems out of sync #215

Closed ArturNiederfahrenhorst closed 2 years ago

ArturNiederfahrenhorst commented 2 years ago

If you are submitting a bug report, please fill in the following details and use the tag [bug].

Describe the bug

Not an actual bug, but I believe your current readme is out of sync with the state of the code.

Screenshot from your readme:

Screenshot 2022-08-11 at 11 27 36

Screenshot from me trying to play with wrappers:

Screenshot 2022-08-10 at 23 27 08

Checklist

pseudo-rnd-thoughts commented 2 years ago

That is strange, I can't replicate your issue. Do you know what your minigrid version is ? Have you updated to the latest version released yesterday?

Dirichi commented 2 years ago

I have the same issue. See this notebook to replicate it: https://colab.research.google.com/drive/1Sp_DWVPsdP5KgRSJJuoy-_iaDw9GlC4H#scrollTo=fQJjpJYypcDc

Version: gym-minigrid-1.1.0

pseudo-rnd-thoughts commented 2 years ago

Could you confirm that is the correct notebook. I have tested it and it raises no error I have added a line wrappers = gym_minigrid.wrappers and no error is raised

Dirichi commented 2 years ago

Oops I mistakenly kept on editing that notebook after sharing it here.

This is a new notebook with the same test: https://colab.research.google.com/drive/15gt5i7AKAU0HevQsCQ4pxyksXsnovDaO#scrollTo=fQJjpJYypcDc

Looks like it works now, not sure what changed. However, I'm still getting the same error in a separate Kaggle notebook. The same version of grid is being downloaded.

https://www.kaggle.com/code/dirichi/muzero-uncertain

rodrigodelazcano commented 2 years ago

@Dirichi and @ArturNiederfahrenhorst can you check if it works now with the latest commit. Fixed in #221

ArturNiederfahrenhorst commented 2 years ago

Installed from e85614b21061cd6713e2b2c4685a860b279090ca and getting the same error.

ArturNiederfahrenhorst commented 2 years ago

Not sure why this is the case though. Install from master with the referenced fix goes well but if I dir(), I don't get what I'd expect from the changed your made. Maybe @Dirichi experiences something else here.

Screenshot 2022-08-22 at 06 19 39
rodrigodelazcano commented 2 years ago

Not sure why this is the case though. Install from master with the referenced fix goes well but if I dir(), I don't get what I'd expect from the changed your made. Maybe @Dirichi experiences something else here.

Screenshot 2022-08-22 at 06 19 39

I'm not able to replicate that same issue. I get the wrappers property when usingdir(). How are you installing gym_minigrid.

Installing from source and pip worked for me:

pip install git+https://github.com/Farama-Foundation/gym-minigrid.git@e85614b21061cd6713e2b2c4685a860b279090ca