Closed MathisFederico closed 1 year ago
I'm not sure how to check if I need to modify anything in the documentation
@MathisFederico thank you, this looks great. Can you add the pytest_mock
dependency under test_requirements.txt.
I think this is the cause of the error in the CI.
@rodrigodelazcano I had put it in test_requirements.txt but the setup.py file was badly configured and did not read it ! You might want to switch to pyproject.toml config instead which is the new standard for python packages.
@MathisFederico our plan is to transition to pyproject.toml in the future, when we can assure that python developers and users have done a complete transition to it. However, if you wish to make an initial PR for future merging that would be great
Hey @MathisFederico . How are the reviewed changes going? :)
Hey @rodrigodelazcano done !
@MathisFederico I think we should remove the extra environment pickable test. Last PR you made already had a great test for this. Can you remove this and also rebase your branch please?
Description
A simple refactoring of the manual_control.py file using a new ManualControl object.
Type of change
Please delete options that are not relevant.
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)