Farama-Foundation / Minigrid

Simple and easily configurable grid world environments for reinforcement learning
https://minigrid.farama.org/
Other
2.09k stars 604 forks source link

🔧 Make env picklable #269

Closed MathisFederico closed 1 year ago

MathisFederico commented 1 year ago

Description

I needed envs to be picklable for using them in multiple process. Thus I fixed the issue that happens to be lambda functions used for missions generation.

Fixes to fact that envs were not picklable.

Type of change

Please delete options that are not relevant.

Checklist:

rodrigodelazcano commented 1 year ago

Thank you for the PR @MathisFederico. I suggest a few changes. I left a comment for the testing function, and could you update the docs for the MissionSpace class (use static method function instead of lambda function).

MathisFederico commented 1 year ago

I suggest a few changes.

Sure ! Where can I find your suggestions ? I don't think you published your review if you have done one !

could you update the docs for the MissionSpace class

Done in last commit !

rodrigodelazcano commented 1 year ago

Thanks! I just tagged you on it, under tests/test_envs.py

MathisFederico commented 1 year ago

Thanks! I just tagged you on it, under tests/test_envs.py

Not sure where to see the tag ... I guess it's on GitHub as I don't see any new commit from your part, but I can't seem to find where you tagged me ^^'

You may want to use GitHub review system, I've had good experiences with that !

rodrigodelazcano commented 1 year ago

@MathisFederico can you see the review now?

MathisFederico commented 1 year ago

Yes ! Sorry I did not have time for now, I may do this tonight if I can find the time !

MathisFederico commented 1 year ago

Done ! @rodrigodelazcano