Farama-Foundation / Minigrid

Simple and easily configurable grid world environments for reinforcement learning
https://minigrid.farama.org/
Other
2.13k stars 610 forks source link

Some typing improvements, add py.typed #284

Closed micimize closed 2 years ago

micimize commented 2 years ago

Description

I did not find a CONTRIBUTING.md but did pre-commit and ensured all tests pass.

Type of change

Please delete options that are not relevant.

Checklist:

micimize commented 2 years ago

@pseudo-rnd-thoughts ok – I've added an --add-import to isort along with autoflake to remove the leftover imports, and changed the ordering to reduce the need for re-running pre-commit (pyupgrade removes need for imports, removing imports effects isort ordering)

I have only really just started using it for my project – some details here: https://github.com/Farama-Foundation/Minigrid/issues/168#issuecomment-1307849050. But would be happy to join the discord – can you resend an invite? It became invalid when discord tried to make me a new account :/

pseudo-rnd-thoughts commented 2 years ago

Thanks for the changes, here is a new link https://discord.gg/N8CwYyGt Could you revert the setup name then we can merge