Farama-Foundation / Minigrid

Simple and easily configurable grid world environments for reinforcement learning
https://minigrid.farama.org/
Other
2.09k stars 604 forks source link

Order placeholders bug fix #304

Closed jbloomAus closed 1 year ago

jbloomAus commented 1 year ago

Description

Fixes self.order_placeholders to self.ordered_placeholders in MissionSpace.__eq__ Fixes #303

Type of change

Please delete options that are not relevant.

Screenshots

Not needed.

To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. -->

Checklist:

Since it's a simple spelling mistake, it's not necessary to comment, edit documentation, or add or modify any tests.

rodrigodelazcano commented 1 year ago

Thanks @jbloomAus ! Actually, this PR solves the same issue as this one https://github.com/Farama-Foundation/Minigrid/pull/288 We didn't merge it because we would like to create a test. @jbloomAus Do you have the time to create this test in this PR?

jbloomAus commented 1 year ago

Hey @rodrigodelazcano,

All good. I've added a test for sync vectorization of environments. The test doesn't evaluate all registered Minigrid environments but enough to trigger the error before the fix which I think is pretty reasonable.

Is that sufficient for a merge?