Farama-Foundation / Minigrid

Simple and easily configurable grid world environments for reinforcement learning
https://minigrid.farama.org/
Other
2.09k stars 604 forks source link

add * to include all subpackages in install #316

Closed jbloomAus closed 1 year ago

jbloomAus commented 1 year ago

Description

Installation of MiniGrid fails to include subpackages such as minigrid.core. I'm surprised no one else has reported this issue so curious for feedback from maintainers. Maybe we should think about a way to ensure the package is important during the release github workflow?

Fixes # Unlisted

>>> conda create -n minigrid python=3.10 -y
>>> conda activate minigrid
>>> pip install MiniGrid==2.1.0
>>> python -c "import minigrid"

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/josephbloom/miniforge3/envs/minigrid/lib/python3.10/site-packages/minigrid/__init__.py", line 3, in <module>
    from gymnasium.envs.registration import register
  File "/Users/josephbloom/miniforge3/envs/minigrid/lib/python3.10/site-packages/gymnasium/__init__.py", line 12, in <module>
    from gymnasium.envs.registration import make, spec, register, registry, pprint_registry
  File "/Users/josephbloom/miniforge3/envs/minigrid/lib/python3.10/site-packages/gymnasium/envs/__init__.py", line 364, in <module>
    load_env_plugins()
  File "/Users/josephbloom/miniforge3/envs/minigrid/lib/python3.10/site-packages/gymnasium/envs/registration.py", line 310, in load_env_plugins
    fn = plugin.load()
  File "/Users/josephbloom/miniforge3/envs/minigrid/lib/python3.10/importlib/metadata/__init__.py", line 171, in load
    module = import_module(match.group('module'))
  File "/Users/josephbloom/miniforge3/envs/minigrid/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "/Users/josephbloom/miniforge3/envs/minigrid/lib/python3.10/site-packages/minigrid/__init__.py", line 5, in <module>
    from minigrid import minigrid_env, wrappers
  File "/Users/josephbloom/miniforge3/envs/minigrid/lib/python3.10/site-packages/minigrid/minigrid_env.py", line 13, in <module>
    from minigrid.core.constants import COLOR_NAMES, DIR_TO_VEC, TILE_PIXELS

Type of change

Please delete options that are not relevant.

Checklist:

<

jbloomAus commented 1 year ago

Happy to help 👍