Closed dm-ackerman closed 1 month ago
AgileRL tutorial is broken again. I think I can fix that and I'll pin the version so it won't be an issue in the future
Tests are failing due to AgileRL version change. #1193 should resolve that.
Apparently the failure to train with SB3 wasn't a bug with the env, it was a SB3 tutorial bug. I removed the change that "fixed" the env because it was wrong. I believe the rest of the changes are valid, but I don't think it requires a version bump, so I moved it back to v3.
Description
Update the TicTacToe environment to v4
Major changes:
Fix termination handling to work with stable baselines3. This now trains as expected with the SB3 PPO codeBump version to 4Minor changes:
Type of change
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no errors are present.pytest -v
has generated that are related to my code to the best of my knowledge.