search

Farama-Foundation / Shimmy

An API conversion tool for popular external reinforcement learning environments
https://shimmy.farama.org
MIT License
129 stars 18 forks source link

Test fail with ale-py 0.9.0 #120

Open GaetanLepage opened 3 months ago

GaetanLepage commented 3 months ago

Since ale-py 0.9.0, the former ale_py.roms.utils has been removed: https://github.com/Farama-Foundation/Arcade-Learning-Environment/blob/v0.9.0/CHANGELOG.md?plain=1#L31

As a result, the test_atari.py errors out:

_____________________ ERROR collecting tests/test_atari.py _____________________
ImportError while importing test module '/build/source/tests/test_atari.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/nix/store/k3701zl6gmx3la7y4dnflcvf3xfy88kh-python3-3.11.9/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_atari.py:8: in <module>
    from ale_py.roms import utils as rom_utils
E   ImportError: cannot import name 'utils' from 'ale_py.roms' (/nix/store/nk77l030y6bwnj88vw0iyyvwbrrsh0k8-python3.11-ale-py-0.9.0/lib/python3.11/site-packages/ale_py/roms/__init__.py)
pseudo-rnd-thoughts commented 3 months ago

Atari will be removed from shimmy very soon as there is no need for it anymore.

GaetanLepage commented 3 months ago

Ok, thanks for the quick answer !