This was a minor typo where the config was not passed into the reloading of a game if the seed was not specified. I also changed the observation/action spaces to match PettingZoo's format, as it isn't very intuitive to have them indexed by number rather than agent ID. The action mask was by agent but the obs space was not. This makes it much more straightforward to adapt this wrapper to be used for other PZ environments (for example Jordan wanted to add Shogi)
Fixes # (issue), Depends on # (pull request)
Type of change
Please delete options that are not relevant.
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Screenshots
Please attach before and after screenshots of the change if applicable.
To upload images to a PR -- simply drag and drop or copy paste.
Checklist:
[ ] I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
[ ] I have run pytest -v and no errors are present.
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
Description
This was a minor typo where the config was not passed into the reloading of a game if the seed was not specified. I also changed the observation/action spaces to match PettingZoo's format, as it isn't very intuitive to have them indexed by number rather than agent ID. The action mask was by agent but the obs space was not. This makes it much more straightforward to adapt this wrapper to be used for other PZ environments (for example Jordan wanted to add Shogi)
Fixes # (issue), Depends on # (pull request)
Type of change
Screenshots
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no errors are present.pytest -v
has generated that are related to my code to the best of my knowledge.