Farama-Foundation / Shimmy

An API conversion tool for popular external reinforcement learning environments
https://shimmy.farama.org
MIT License
139 stars 20 forks source link

OpenSpiel: fix reset() with no seed, make obs/act spaces match PettingZoo #97

Closed elliottower closed 1 year ago

elliottower commented 1 year ago

Description

This was a minor typo where the config was not passed into the reloading of a game if the seed was not specified. I also changed the observation/action spaces to match PettingZoo's format, as it isn't very intuitive to have them indexed by number rather than agent ID. The action mask was by agent but the obs space was not. This makes it much more straightforward to adapt this wrapper to be used for other PZ environments (for example Jordan wanted to add Shogi)

Fixes # (issue), Depends on # (pull request)

Type of change

Please delete options that are not relevant.

Screenshots

Please attach before and after screenshots of the change if applicable. To upload images to a PR -- simply drag and drop or copy paste.

Checklist: