Farama-Foundation / ViZDoom

Reinforcement Learning environments based on the 1993 game Doom :godmode:
https://vizdoom.farama.org/
1.72k stars 398 forks source link

Game argument "timelimit" breaks new_episode if used in PLAYER mode and too high episode_timeout #100

Open Miffyli opened 8 years ago

Miffyli commented 8 years ago

Using "timelimit" game argument (eg. "+timelimit 2.0") in game with PLAYER mode and too high episode_timeout results to episodes after first one only last for few loops.

For example: Gameargs with "+timelimit 2.0", episode_timeout = 10000 and PLAYER mode. First episode lasts 4200 loops, but following episodes only last ~30 loops. However if timelimit is 2000, at least 10 first episodes work as expected. I have attached a modified cig_bots.py that can be used to replicate the issue.

cig_bots_issue.zip

I am using prebuilt 1.1.0pre build on Windows 10.

mwydmuch commented 8 years ago

I was aware of this and I thought that I fixed this. Well, I'll look at it again. Anyway, when "+timelimit" argument is used, episode_timeout may be omitted, episode will also end correctly when in-game time runs out.

wjaskowski commented 8 years ago

Bug confirmed on Linux.

Wojciech Jaśkowski, Ph.D. Laboratory of Intelligent Decision Support Systems Institute of Computing Science Poznan University of Technology, Poland http://www.cs.put.poznan.pl/wjaskowski

On 22 July 2016 at 17:29, Anssi notifications@github.com wrote:

Using "timelimit" game argument (eg. "+timelimit 2.0") in game with PLAYER mode and too high episode_timeout results to episodes after first one only last for few loops.

For example: Gameargs with "+timelimit 2.0", episode_timeout = 10000 and PLAYER mode. First episode lasts 4200 loops, but following episodes only last ~30 loops. I have attached a modified cig_bots.py that can be used to replicate the issue.

cig_bots_issue.zip https://github.com/Marqt/ViZDoom/files/378520/cig_bots_issue.zip

I am using prebuilt 1.1.0pre build on Windows 10.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Marqt/ViZDoom/issues/100, or mute the thread https://github.com/notifications/unsubscribe-auth/AEuSHXKH9LH3shh01fYyMPEJt3WfMl3qks5qYOH0gaJpZM4JS3pk .