Closed elliottower closed 1 year ago
@yuxiang-wu let me know if you see any issues with the wrapper, as I said I’m not 100% sure the way of doing observation spaces and action spaces is best for example. And there should probably be some testing as well but I didn’t have time to write that.
Thanks! I merged it to the dev
branch and I will do so testing and code review before releasing it to the main
branch.
Makes sense, thanks!
On Thu, May 11, 2023 at 7:52 PM Yuxiang (Jimmy) Wu @.***> wrote:
Thanks! I merged it to the dev branch and I will do so testing and code review before releasing it to the main branch.
— Reply to this email directly, view it on GitHub https://github.com/chatarena/chatarena/pull/33#issuecomment-1544904016, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHVPVAZOHHOYGE3VJTZ6BKDXFV3VLANCNFSM6AAAAAAX5CTAKU . You are receiving this because you authored the thread.Message ID: @.***>
I believe this should be almost finished, as it works for my purposes, but I would be interested to hear feedback about it. I structured it the same way as we generally do https://github.com/Farama-Foundation/shimmy conversion wrappers (with similar naming) so it could also be included there.
https://github.com/chatarena/chatarena/issues/14
I added a basic example script (can use one of the other examples as well, this was just what I was using locally and testing with) and a short MD file showing how to use it.