[Proposal] Add type hinting where reasonable - Githubissues

Farama-Foundation / miniwob-plusplus

MiniWoB++: a web interaction benchmark for reinforcement learning

https://miniwob.farama.org/

MIT License

280 stars 47 forks source link

[Proposal] Add type hinting where reasonable #14

Closed ppasupat closed 1 year ago

ppasupat commented 1 year ago

Proposal

Add type hints and enable the Pyright type checker in git pre-commit.

Motivation

Type hint is part of the Farama project standards: https://farama.org/project_standards.

Pitch

Add type hints to all files inside the miniwob package. Use type hint features compatible with the oldest supported Python (3.7).
Enable Pyright type checker in git pre-commit (currently it is commented out).

Alternatives

None.

Additional context

None.

Checklist

[x] I have checked that there is no similar issue in the repo (required)