Farama-Foundation / miniwob-plusplus

MiniWoB++: a web interaction benchmark for reinforcement learning

https://miniwob.farama.org/

MIT License

287 stars 47 forks source link

Refactored Selenium-specific code out of action.py #72

Closed ppasupat closed 1 year ago

ppasupat commented 1 year ago

Description

Group Selenium-specific code together so that future backends (alternatives to Selenium) can be integrated. The external-facing API remains the same.

Moved Selenium-specific action execution code from action.py to selenium_actions.py
Renamed instance.py to selenium_instance.py

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes