search

Farama-Foundation / stable-retro

Retro games for Reinforcement Learning
https://stable-retro.farama.org/
MIT License
163 stars 34 forks source link

windows 3.10 build capability #15

Closed onaclov2000 closed 1 year ago

onaclov2000 commented 1 year ago

Calling build_windows.bat on a system that has docker installed should build you a whl file, at which point you can pull it out of the container, and pip install it, and it works on windows.

onaclov2000 commented 1 year ago

I'm not sure why the pre-commit is failing, I thought the flake8 or whatever stuff automatically fixes certain issues and doesn't fail on that, based on the output it looks like it's complaining about trailing whitespace?

onaclov2000 commented 1 year ago

Finally ran flake8 stuff locally so pre-commit passes.

pseudo-rnd-thoughts commented 1 year ago

@onaclov2000 Would you be able to add a version of this that runs in CI with github actions? I think that we can run it with a single version. This will just allow us to know that the windows build still works and none of our other code breaks

onaclov2000 commented 1 year ago

@pseudo-rnd-thoughts I don't know a whole lot about github actions yet, I'm not sure how to either call docker, and run docker, or call all the commands referenced in docker individually if that makes sense. I might give it a shot later, but I'm not sure how fast I'll be able to do that.

pseudo-rnd-thoughts commented 1 year ago

For reference, this is how we do docker based CI testing in gymnasium - https://github.com/Farama-Foundation/Gymnasium/blob/main/.github/workflows/build.yml

onaclov2000 commented 1 year ago

Ahh not sure how I missed that, interesting. Does it actually build the package for each of the tested targets?