search

Farama-Foundation / stable-retro

Retro games for Reinforcement Learning
https://stable-retro.farama.org/
MIT License
162 stars 34 forks source link

Fix installation with git via pip #37

Closed zbeucler2018 closed 1 year ago

zbeucler2018 commented 1 year ago

Fixes the bug in this issue

zbeucler2018 commented 1 year ago

@pseudo-rnd-thoughts I'm a little confused, could you emphasize further? The reason I had to wrap this in a try/except is because when the project is installed via pip install *.whl or pip install git+... , the retro/VERSION file isnt included in the install, which was the cause of the original bug

pseudo-rnd-thoughts commented 1 year ago

To my understanding, the file is rather retro/../VERSION, i.e., just VERSION in the root folder We might need to update https://github.com/Farama-Foundation/stable-retro/blob/ee019a6d58f43cefdea3f7021553572625b3c736/setup.py#L104 to VERSION rather than VERSION.txt but this seems unrelated

pseudo-rnd-thoughts commented 1 year ago

Trying the colab, I found that none of the package data was included, therefore, I think there is an issue with that. I found the workaround was to put the VERSION file in retro only. Previously, the project had two version files however to me this seems like a stupid idea that can cause issues and is easier to have a single file for this.

zbeucler2018 commented 1 year ago

I agree, two version files is a bad idea. I can implement that workaround later today

zbeucler2018 commented 1 year ago

Issue has been fixed. @pseudo-rnd-thoughts please take another look when you have a free second, thank you! Screenshot 2023-07-14 at 10 59 07 PM