Farama-Foundation / stable-retro

Retro games for Reinforcement Learning
https://stable-retro.farama.org/
MIT License
163 stars 34 forks source link

Ci fixes #8

Closed onaclov2000 closed 1 year ago

onaclov2000 commented 1 year ago

Updated per the issue noted #7 . I ran python -m pre_commit run --all-files in a docker container, the only thing failing from that command is the following:

flake8...................................................................Failed
- hook id: flake8
- exit code: 1

I'd claim that we should merge this, and then we can assess if this affects the "successful" build of the CI.

pseudo-rnd-thoughts commented 1 year ago

@onaclov2000 Thanks for the update, the CI for pre-commit is still failing and looking at the items there is a significant number for flake8. Could you see if those can be solved? If not, possible a possibly explanation for what is happening

FYI, you can run pre-commit run --all-files locally in the project without docker

onaclov2000 commented 1 year ago

First thing: https://github.com/Farama-Foundation/stable-retro/actions/runs/5065024672/jobs/9099863581?pr=8#step:7:48

That is complaining about movie.py, and that line isn't in the file anymore so I'm not sure what is going on there, is the precommit action pulling the actual merge request to test?

The flake8 stuff is identified by the F numbers, at first glance we can clean a bunch up by removing unused imports, etc.