search

Farata / angular2typescript

Code samples from the book Angular 2 Development with TypeScript
MIT License
440 stars 270 forks source link

Chapter 5 : observable-events-http.ts #28

Closed mesrine closed 7 years ago

mesrine commented 7 years ago

Not really an error, but confusing for a beginner like me ;)

Line 19: selector: "app-root",

according to the other examples selector: "app",

yfain commented 7 years ago

I agree, naming selectors could have been more consistent. In Angular CLI-generated project, it's consistent - the default selector is app-root unless you change the prefix property during the project generation or in the file .angular-cli.json.

The code samples in the Angular4 directory where generated with Angular CLI and the naming should be consistent there.