search

FarazzShaikh / THREE-CustomShaderMaterial

Extend Three.js standard materials with your own shaders!
Other
846 stars 54 forks source link

Waves example seems to be broken #40

Closed gabrieljreed closed 1 year ago

gabrieljreed commented 1 year ago

The waves example shown in the README seems to be broken: This is the result I see running it on both Firefox and Chrome:

image

The other examples work fine, just thought you'd want to know that the waves example seems to be down.

FarazzShaikh commented 1 year ago

This is a bug related to CodeSandbox where React spring (which is used in Drei) tends to fail. I’ve seen it multiple times across multiple boxes.

Can you try forking the example and updating the dependencies?

gabrieljreed commented 1 year ago

Sorry for the late reply, I built locally and was able to run the example just fine. I'm afraid I don't have much experience with CodeSandbox, so I'm not sure how to help there. I just did the normal install, nothing needed to be updated (I have no changes to the package.json). Let me know if there's anything else I can do to help!

FarazzShaikh commented 1 year ago

Thank you for your investigation! This seems like problem in react-spring. I will update the dependencies to see if that fixes it, if not then this can’t be fixed here.