FarbstoffRSL / RSL-Helper

Der Farbstoff RSL-Helper
234 stars 180 forks source link

Suggestion: Abort run after a time limit (Paragon detection) #183

Closed verdesmarald closed 2 years ago

verdesmarald commented 3 years ago

It is possible for a run to get stuck in an infinite loop, most notably when an enemy Basilisk or Paragon is unkillable and stuck at 0 turn meter. Several times I have woken up in the morning to find my overnight farming stuck in a 5-hour run.

Since RSL is already tracking the run time, I suggest to let the user set a maximum time in the autoclicker, e.g. 10 minutes, and automatically aborting the run if the limit is reached.

JABirchall commented 2 years ago

+1 this, would be usefull on fireknight as well. I sometimes have runs on fireknight that never end.

FullSilence commented 2 years ago

+1. Only as a separate option with timestamp.

Dwza commented 2 years ago

Hm, whats the exact point? I mean, does it metters if he abort or run? The result is the same "nothing happens" and if this situation occures often, you may shold consider to change you team that such things wont come up so often :D so i really dont see the "need" in this situation.

verdesmarald commented 2 years ago

Hm, whats the exact point? I mean, does it metters if he abort or run? The result is the same "nothing happens" and if this situation occures often, you may shold consider to change you team that such things wont come up so often :D so i really dont see the "need" in this situation.

The result is very much not the same - say you are running FK25 overnight with a team that takes ~5mins/run and occasionally (1-2%) gets stuck hitting an unkillable Gnarlhorn forever in Round 1.

If RSL aborts the run after 10 minutes, you wake up in the morning and see 158/160 runs succeeded. Without the abort you wake up and see 8/8 runs succeeded and your Allure has been hitting Gnarlhorn for 400 minutes.

Dwza commented 2 years ago

my longest fight was ~680 mins. startet helper before i went to work :D now i get your point. i'll pass this to farbstoff.

JABirchall commented 2 years ago

Same with paragon, my FW24 team sometimes get stuck on paragon if they dont kill him first. If hes last alive, the run will last for ever, since paragn cant kill my team alone, and my team cant kill paragon.

Dwza commented 2 years ago

actually you should bring stun into your team, this would solve this issue with game possibilities :)

github-actions[bot] commented 2 years ago

This issue is stale because it has been open for 7 days with no activity.

github-actions[bot] commented 2 years ago

This issue was closed because it has been inactive for 7 days since being marked as stale.