Farcr / vanity

MIT License
1 stars 2 forks source link

[Feature Request]: Config to disable item requirements/add valid items for styles #21

Open AliceCarlin opened 3 months ago

AliceCarlin commented 3 months ago

Is your feature request related to a problem?

I use a lot of mods that add tools, including in unconventional ways (like Tetra, that does not add unique items, bit rather a modulable tool system). Because vanity seems to only allows a few precise items to be modified in the stylist table, I cannot apply Vanity styles to my gear.

Solution(s)

Maybe there could be a config option to either disable specific item requirements for styles (may be a bit chaotic for players with lots of styles, but can be remedied by temporarily taking styles out of the stylist table and generally allows more player freedom), or to add item ids that can be stylized?

Describe alternatives you've considered

I'm not going to lie, I'm asking mainly so I can reconcile both Vanity and tetra, but a config seems easier to implement than tetra compatibility.

Mod Version

2.1.1

Mod Loader Version

1.20.1 - 47.2.0

Mod Loader

Forge

Additional context

Lovely mod! Love it so far. I'm not sure how feasible what I'm suggesting is considering allowed items seem to be defined on a per-pack basis but I figured it cost nothing to ask, have a nice day

Feranogame commented 3 months ago

It shouldn't be hard to fix that for yourself with a datapack, but yeah the thing is that whoever made the vanity packs you are using probably just didn't set up mod compat by using tags, so you could say it is "intended". I can see how this would be easier for players though, but it might be hard to implement considering styles can have multiple different models for different items, so the game wouldn't know which to chose, and if all were displayed it'd end up leading to many broken models. I personally tend to just make my styles compatible with tags, so they should work with anything, but many Vanity developers opt into only letting certain tool tiers have a design or make unique textures for different materials, which isn't really compatible with this approach.