search

Farcrada / DiscordPlugins

This repo holds all the plugins I made for Discord.
GNU Affero General Public License v3.0
114 stars 66 forks source link

[Hide Channel] Add option to hide channels by default in the settings #118

Open RecentRunner opened 1 year ago

RecentRunner commented 1 year ago

Is your request related to a problem? Please describe.

I love the Hide Channel plugin, however there's only one thing I would change. I want the channels to be hidden be default and then shown by pressing the hotkey

Describe the solution you'd like

A toggle inside of the BetterDiscord setting would be nice addition for this

Describe alternatives you've considered

No response

Additional context

No response

Farcrada commented 1 year ago

That's a good idea.

Would you see this as a default option being either closed or opened? Or some sort of memory function of the last toggle?

RecentRunner commented 1 year ago

Would you see this as a default option being either closed or opened?

I would say default as open and then the user can set it to whatever they want afterwards

Or some sort of memory function of the last toggle?

I'm also okay with this. I can't imagine a situation where it would be frowned upon, but perhaps something like that would be a different toggle? Not too sure to be honest, I would say do whatever easier to implement

TheArkive commented 1 year ago

The current plugin leaves the user profile icon, mic/speaker control, and settings icons visible, and overlaps the typing bar. Also the emoji icons crowd out input editbox for typing.

image

Hopefully this can be accounted for. Maybe hide those icons with an arrow icon to expand or something?

Other than that, just wanted to chime in and say I am TOTALLY for this modification.

refriedfood commented 1 year ago

I would also like the chat icons to be hidden by default (or at least the option to turn that on).

TheArkive commented 1 year ago

I would also like the chat icons to be hidden by default (or at least the option to turn that on).

There is an addon to do that actually (found it recently):

Hide Chat Icons

EDIT: I just wanted to add that for me, almost all themes are now properly hiding the user avatar, mic/headphone/settings icons. I unfortunately didn't read thoroughly, but something was updated recently, and it wasn't 15+ themes at once.

I have the following plugins:

ZeresPluginLibrary was recently updated. Not sure what is affecting what at this point. But again, almost all themes now properly hide those icons.

refriedfood commented 1 year ago

@TheArkive That plugin is literally the one I'm suggesting has the option by default. We're in that repo.

TheArkive commented 1 year ago

@refriedfood I understand. I'm not confused about which repo we're in. I was just saying that I found a solution to a problem that I experienced related to this plugin, but it was a bit off-topic. Sorry, didn't mean to go OT.

On a separate note, you gave a thumbs up to my first post about how some UI elements are overlapping. I was also trying to say that this issue is no longer happening with my current combination of plugins with most themes.

TheArkive commented 1 year ago

Back to the topic, another thing to consider is what happens when Discord closes:

EDIT: Currently, the glyph used to collapse the channel list is not visible when Discord first starts up on PM chat windows, and the Ctrl+H hotkey doesn't work initially in this case also. I have to actually select a server/channel/PM chat to see the glyph and/or use the hotkey in this case. And the window width on close seems to be offset with the width of the channel list added to the width on close.

If i have a server/channel active when I close Discord, then when restarting Discord, the glyph is visible and the hotkey works as expected.

Please correct me if I'm wrong, but I figure all these things are related to making the panel open/closed by default. I'm not trying to go off topic.

Farcrada commented 1 year ago

Alright. First of all, thank you all for the interest and improvement these plugins bring you all. However this issue pertains a very specific topic, as per the title.

@TheArkive the overlapping issue was fixed with this issue: https://github.com/Farcrada/DiscordPlugins/issues/122 I have since renamed it to make identification and finding it easier. Zere's library had some updater issues as does the BD build-in updater, but that's outside of my control.

@refriedfood I would like to request you open a separate issue for that plugin with your (enhancement) request about automatically having it hidden.

Enfin. Back to the issue at hand.

The glyph (and thus it's functionality) needs to be loaded in by discord. I haven't been able to get the glyph to appear reliably when I close and start Discord again, it simply brings me to the Friends-tab as well. It can only do that when Better Discord has injected the plugin into the current render. Unfortunately there's an order to things and this means that injections like this take a re-render (when counting from cold starts). With that comes the disability (out of the box) to enable hiding by default. As you'd have no way to actually open it again.

I'll look into forcing a re-render, but it'd add in potential breaking points if browsing Discord will be the first thing you do when you open it anyway. As soon as you browse anywhere (except settings) in Discord: the button appears; right when you might need it.

TheArkive commented 1 year ago

Understood @Farcrada. I didn't mean to cause a problem. Sorry if I did.

I actually don't mind a little extra navigation. I was just trying to help. Admittedly, I wasn't sure of what the possibilities would be to make the functionality more smooth/intuitive. It sounds like it might not be worth it if more breaking points are introduced.

Thanks for your work on these plugins. They really do make Discord better.

Farcrada commented 1 year ago

You're good. I'll put it on the list, see what I can come up with.