search

Farfetch / kafkaflow-retry-extensions

Kafka Flow Retry Patterns Extensions
https://farfetch.github.io/kafkaflow-retry-extensions/
MIT License
57 stars 7 forks source link

Remove Newtonsoft dependency #150

Open dtkujawski opened 7 months ago

dtkujawski commented 7 months ago

Describe the solution you'd like

While KafkaFlow allows use of either CoreJson or Newtonsoft through KafkaFlow.Serializer.JsonCore and KafkaFlow.Serializer.Newtonsoft, KafkaFlow-Retry (the durable code) is hard-coded to use Newtonsoft directly.

For projects that want to reduce unnecessary dependencies and are using CoreJson, this dependency can't be avoided.

It would be nice if the Durable retry code used the same serializer/deserializer as the main KafkaFlow (ISerializer & IDeserializer)

Are you able to help bring it to life and contribute with a Pull Request?

No

luispfgarces commented 5 months ago

Hi @dtkujawski,

Thank you for reaching out and for your suggestion. We have discussed your request internally and we'll assess the feasibility of it as soon as we find the time to do so.