Farfetch / kafkaflow-retry-extensions

Kafka Flow Retry Patterns Extensions

https://farfetch.github.io/kafkaflow-retry-extensions/

MIT License

55 stars 7 forks source link

Change log level of retry simple attempt #86

Closed sergiosimoes025 closed 1 year ago

sergiosimoes025 commented 2 years ago

Description

The log level of attempts of the simple retry definition is Error. Since this is a retry attempt, the log level should be Verbose.

This PR changes the log level of the retry attempt to Verbose.

Fixes #85

How Has This Been Tested?

Test the consumption of events locally, and ensure that the log level of the retry attempt is verbose.

Checklist

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[ ] I have added tests to cover my changes
[ ] I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

fernando-a-marins commented 1 year ago

After some conversation with the finance open-source team, we concluded that this PR shouldn't be merged. The users may accomplish this issue using the retry durable and using some metadata that flows in the headers of the messages. In the property IMessageContext.Headers you will find a header with the key "Kafka-Flow-Retry-Durable-Attempts-Count" that will give you the number of attempts, if zero, it means that the message is not in retry. Use that to log as you wish in your applications.