Farfetch / loadshedding

A .NET library created to assist the applications in applying LoadShedding techniques and making it easy to configure it

https://farfetch.github.io/loadshedding/

MIT License

85 stars 10 forks source link

docs: fix samples broken link #11

Closed QzLP2P closed 6 months ago

QzLP2P commented 6 months ago

Link was wrong

Description

The link in samples.md was wrong

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have added tests to cover my changes
[x] I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

joelfoliveira commented 6 months ago

Hi @QzLP2P ,

Thank you for your contribution. As per the Contribuiting Guidelines, can you please change the commit message to follow the conventional commits guideline?

Maybe something like: docs: fix samples broken link

simaoribeiro commented 6 months ago

Hi @QzLP2P , I noticed that you changed the PR title to the one suggested by @joelfoliveira . Can you also reword the commit title from Update samples.md to the docs: fix samples broken link to follow our guidelines? Thanks

QzLP2P commented 6 months ago

Hi @QzLP2P ,

Thank you for your contribution. As per the Contribuiting Guidelines, can you please change the commit message to follow the conventional commits guideline?

Maybe something like: docs: fix samples broken link

I tried from github.com but I can’t rewrite the commit message. Tomorrow I Will clone the repo to do it

QzLP2P commented 6 months ago

I finally create a new one, more simple for me https://github.com/Farfetch/loadshedding/pull/13