Closed hades200082 closed 4 months ago
Hi @hades200082 ! Thanks for reporting the issue, we'll investigate and give you a feedback.
Has there been any progress tracking this down? It's the only thing stopping me really using LoadShedding right now.
Has there been any progress tracking this down? It's the only thing stopping me really using LoadShedding right now.
Hi @hades200082! I've created a PR with the fix https://github.com/Farfetch/loadshedding/pull/24
Has there been any progress tracking this down? It's the only thing stopping me really using LoadShedding right now.
Hi @hades200082! I've created a PR with the fix #24
Awesome news! I'll give it a try
Prerequisites
Description
I have a .Net 8 WebAPI that I've been building out and I added LoadShedding to it today.
I've noticed now that any time an exception would be thrown, returning a 500 error to the client it instead returns an empty 200 response instead.
Steps to reproduce
The same issue happens for Unauthorized responses:
If you hit this endpoint while not authenticated you also get a blank 200 response.
Expected behavior
I'd expect error responses to be preserved so that client applications can respond correctly.
Actual behavior
A blank 200 response is returned for errors.
LoadShedding version
1.0.0