Fix issue in dates used in rules matching - Githubissues

Farfetch / rules-framework

A generic framework that allows defining and evaluating rules for complex business scenarios.

MIT License

40 stars 7 forks source link

Fix issue in dates used in rules matching #123

Closed jdromeiro closed 1 year ago

jdromeiro commented 1 year ago

Description

Changes current Tests namespaces in IntegrationTests to Scenarios
Creates Features namespaces in IntegrationTests
Creates tests for verifying correct matching of rule dates
Fixes issue with rules dates matching -> Closes #93 .
Fixes typo in PriorityCriteria
Replaces explicit variables by implicit variables (var) in Rules.Engine

Change checklist

[ ] Code follows the code rules guidelines of this project
[ ] Commit messages follow the commit rules of this project
[ ] I have self-reviewed my changes before submitting this pull request
[ ] I have covered new/changed code with new tests and/or adjusted existent ones
[ ] I have made changes necessary to update the documentation accordingly

Please also check the I want to contribute guidelines and make sure you have done accordingly.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

jdromeiro commented 1 year ago

ℹ️ The logic for the definition of the dates filter was based on the first answer on this thread.