Refactor benchmarks scenarios for reuse as test scenarios - Githubissues

Farfetch / rules-framework

A generic framework that allows defining and evaluating rules for complex business scenarios.

MIT License

40 stars 7 forks source link

Refactor benchmarks scenarios for reuse as test scenarios #144

Closed luispfgarces closed 1 year ago

luispfgarces commented 1 year ago

Description

Moved the benchmarks scenarios from the benchmarks project to the integration tests common project, so that those scenarios can be re-used on integration tests.
Created an integration test for the scenario that uses Texas Hold'em Poker combinations.
Added logic to benchmarks so that they can be run via the command line (future PR). Also added logic to complement the information gathered when running benchmarks on a Windows OS.

Change checklist

[x] Code follows the code rules guidelines of this project
[x] Commit messages follow the commit rules of this project
[x] I have self-reviewed my changes before submitting this pull request
[x] I have covered new/changed code with new tests and/or adjusted existent ones
[x] I have made changes necessary to update the documentation accordingly

Please also check the I want to contribute guidelines and make sure you have done accordingly.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

luispfgarces commented 1 year ago

@jdromeiro and @carlosgoias can you please review again? I have also refactored the RulesFromJson class used at integration tests to use the new fluent API to build the conditions.