Replace conditions collection with dictionary - Githubissues

Farfetch / rules-framework

A generic framework that allows defining and evaluating rules for complex business scenarios.

MIT License

41 stars 8 forks source link

Replace conditions collection with dictionary #172

Closed luispfgarces closed 1 month ago

luispfgarces commented 2 months ago

Description

For performance reasons, this PR replaces the references:

IEnumerable<Condition<TCondition>> by IDictionary<TCondition, object>
IEnumerable<Condition<string>> by IDictionary<string, object>

[!WARNING] BREAKING CHANGE: conditions are no longer accepted via a collection of Condition and a dictionary is accepted instead. As such, all calls to MatchOneAsync(...), MatchAllAsync(...), and SearchAsync(...) will need adjustment to provide a dictionary of conditions alternatively.

Change checklist

[x] Code follows the code rules guidelines of this project
[x] Commit messages follow the commit rules of this project
[x] I have self-reviewed my changes before submitting this pull request
[x] I have covered new/changed code with new tests and/or adjusted existent ones
[ ] I have made changes necessary to update the documentation accordingly

Please also check the I want to contribute guidelines and make sure you have done accordingly.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement