search

Fargus811 / Competition

0 stars 0 forks source link

ShowAllCoachesCommand #39

Open VladOsipov opened 4 years ago

VladOsipov commented 4 years ago

process() method

  1. Please remove magic numbers
  2. Why don't you use StringUtilsto join coaches ? As you do inCoachFileWriter
  3. Please think about this line. all.size() == 0 We have the way to make this line more clear

readWideList() method

  1. I dont like method's name :)
  2. This method looks too complex. Please try to reduce complexity
  3. for (; counter < pageSize * page; counter++) What's wrong with this line?
  4. Main logic of this method is inside catch block. Catch blocks should NOT contain such logic

Also please think about only one layer for input. I mean all input is in Mainclass now