search

FaridSafi / react-native-gifted-chat

💬 The most complete chat UI for React Native
https://gifted.chat
MIT License
13.56k stars 3.55k forks source link

add isKeyboardInternallyHandled to allow custom logic again #2541

Open ImBeCiliC opened 2 months ago

ImBeCiliC commented 1 month ago

@kesha-antonov this should resolve these issues + adding back the functionality of having a custom keyboard handler Fixes: https://github.com/FaridSafi/react-native-gifted-chat/issues/2523 https://github.com/FaridSafi/react-native-gifted-chat/issues/2504

JoniVR commented 1 month ago

I agree that this option should be present, however, this current implementation doesn't remove the functionality entirely. The useAnimatedKeyboard reanimated hook also manipulates default adjustResize behavior. The hook is not unmounted in this implementation, so I assume this manipulation will remain present. See: https://docs.swmansion.com/react-native-reanimated/docs/device/useAnimatedKeyboard/#remarks

So ideally, the keyboard implementation gets implemented and lazily imported into the file.