Bug fix - cannot use dynamic strings within image require statements

FaridSafi / react-native-gifted-form

📝 « One React-Native form component to rule them all »

MIT License

1.44k stars 214 forks source link

Bug fix - cannot use dynamic strings within image require statements #62

Closed samdturner closed 8 years ago

samdturner commented 8 years ago

This PR is related to #61.

The JavaScript files need to be statically analyzed in order to be bundled. You cannot use dynamic strings. I have tested the forked repo in our app and it works as expected.

For more info, checkout: https://github.com/facebook/react-native/issues/2481

gabceb commented 8 years ago

Have not tested but it looks good :shipit:

pppluto commented 8 years ago

agree with @gabceb

FaridSafi commented 8 years ago

thank you @samdturner