search

FaridSafi / react-native-gifted-form

📝 « One React-Native form component to rule them all »
MIT License
1.44k stars 214 forks source link

Update example to react native version 0.39.0 + Few fixes #93

Closed farazshaikh closed 7 years ago

farazshaikh commented 7 years ago

The example app needed -import react from 'react' -some (moment) dependancies added to package.json

Fix for validator > 0.4.0 -Uptil validator 0.4.0 validate functions were able to handle undefined and objects. -After 0.4.0 they all expect strings. So modified the _onValidate of the form manager to do the conversion to string.

Thanks Faraz

cooperka commented 7 years ago

We should probably merge https://github.com/FaridSafi/react-native-gifted-form/pull/84 first to minimize conflicts :)

cooperka commented 7 years ago

Hi @farazshaikh, thanks for these fixes! I've just been made collaborator and I'm trying to merge some existing PRs. Would you mind rebasing this on master now?

cooperka commented 7 years ago

Closing due to inactivity, feel free to reopen. Another PR was recently merged as well that fixed the example app. Thanks!