Closed sambwest closed 7 years ago
Hi @sambwest, thanks for the PR, this looks great! I'll just need to test it before merging of course, which will hopefully be this weekend if I can make the time. I've got it on my to-do list.
Thanks @cooperka!
FYI I removed your second commit (da999c3, suppress keyboardShouldPersistTaps error) and manually added it to master. It's out of the scope of this PR so I wanted to separate them. Thanks for that as well!
Wait a minute... that's the opposite of what we want! I've reverted that commit now. The latest version of React Native expects 'always'
, not true
.
To be clear, this PR was merged successfully. I just excluded your second commit.
Yeah no problem, understood. Thanks @cooperka another one off the list!
Hi @cooperka,
Glad to see someone is taking control of this repo. Any chance I can get the following merged in?
1) Moved error generation to GiftedManager so that the form may be submitted programmatically
2) Exposed the google places response details in GooglePlacesWidget
This is just to give access to the underlying response as there are elements I personally required and there is no halm in exposing them.