Open bell-steven opened 4 years ago
Hi! Which props are you thinking of getting rid of? Where can I find more information about getting started on that one? @bell-steven
@ynigoreyes I have a google sheet you can view here. It's still a work in progress. Would love your input. I can invite you to edit. Work will be done in the v2 branch, I just have to push it from my computer.
Look into splitting up the component based on the type of Google Maps API you want to use.
I think this library serves only one propose and I don't see any reasonable splitting! Can you elaborate?!
@strdr4605 the library in its current state can do a few things. 1) autocomplete an address/place search 2) find nearby places 3) get address from current location 4) get place details from address/place search
Each of these functions uses a different api, and has unique query parameters. I wrote a pretty detailed breakdown of all of this here.
The idea would be to 'split' some of the functionality up to make it easier to use the library. As an example
import { GooglePlacesAutocomplete } from "react-native-google-places-autocomplete"
might turn into something like
import { GetNearbyPlaces, GoogleAutoComplete, GetAddressFromLocation } from "react-native-google-places-autocomplete"
I created a v2
branch. Please create all breaking/major changes against that branch.
Would be it be feasible to request the ability to customize the Current Location button?
E.g. I'd like to be able to give it props or pass it a function to render a pre-defined button.
@QuintonC this sounds like a question/feature request. Please open a separate issue.
Short term goals:
Long terms goals:
If you are willing to contribute by taking a task and creating PRs, that would be most appreciated (and will really speed things up). Sound off below