Farigh / pokeclicker-automation-desktop

Desktop packaging of https://github.com/Farigh/pokeclicker-automation
4 stars 1 forks source link

Ephenia Autoclicker Freeze #22

Closed NAFEDUDE closed 1 year ago

NAFEDUDE commented 1 year ago

Using Ephenia's autoclicker script causes the game to hang on load. I have already changed the final lines myself, and it does this even if every other script is turned off.

image

Farigh commented 1 year ago

Hi,

It seems to be a problem on Ephonia's script side. image

It's looking for a variable that was never defined. This variable is not part of the game either : image

I don't know why the game stopped working, but I couldn't tell you since I don't know what this script is doing.

In general, I'm not in charge of maintaining those external scripts, thus any issues with those should be reported on their author's repository.

Farigh commented 1 year ago

I changed the code evaluation method via #23 This new method is more secure and is less strict on JS syntaxe, which should address your problem

The update should dispatch automatically to your system, once merged

NAFEDUDE commented 1 year ago

Hey! Sorry if I caused any trouble. It was such an odd issue I honestly didn't know who to contact, since it wasn't throwing an error to me at all, the game basically softlocked upon launch. Thank you for looking into it on the end of your scripts; if issues persist I will inform Ephenia. I was able to manually fix the other reported bug on those scripts and even submitted a merge request on their end to fix it.

Edit: That solved it! Thank you.

Farigh commented 1 year ago

No problem at all.

The problem was due to the lack of compliance with strict JavaScript declaration. It's still an issue on Ephenia's scripts side but most modern browser fix those problems silently.

It allowed me to use a more secured and performant method so I'm glad this pushed me into looking into it.

NAFEDUDE commented 1 year ago

I was going to say, it seemed like it was still a benefit in the end to bring it up here. I'm glad it worked out that way. Thanks again!