search

Farigh / pokeclicker-automation

An automation script suite for pokeclicker.com
GNU General Public License v3.0
37 stars 19 forks source link

Catch filters set by automation are in wrong order for ideal/expected use #303

Closed Lokilotus closed 1 year ago

Lokilotus commented 1 year ago

Describe the bug

Catch filters set by automation are in wrong order for ideal/expected use.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Reorder catch filters while automation is off to "Caught, Automation, Caught Shiny, New, New Shiny", going down the list.
  2. As expected, the lowest filter is used, e.g. New Shinies always are caught with a Master Ball.
  3. Turn on automation and let it reorder the filters.
  4. Now no shinies, new or otherwise, will be caught, unless the automation wants them to be; in addition this breaks the flow of quests that ask for shinies to be caught while other quests are ongoing (will try to catch them, but not with any guarantee unlike setting the shiny filter to a Master Ball) as the automation makes the shiny quest the lowest priority quest to complete from what I can tell.

Expected behavior

The more specific a filter is, the lower down it should be by default - i.e. New Shinies, then New (or Caught Shinies), then Caught Shinies (or New), then either the automation or caught, depending on preference.

Additional context

Would be resolved by implementing feature described in https://github.com/Farigh/pokeclicker-automation/issues/295#issue-1699067385.

Farigh commented 1 year ago

Hi,

The implementation of #295 will only skip the Automation filter being moved last, if it's not.

For now, if you reorder your filters, only the automation one should be moved last (so it can have priority, as you rightly said) and your filter's order should be kept as-is.

Did you experiment another behavior ? If so, which browser are you using so I can try to figure out what happens.

Lokilotus commented 1 year ago

Setting the order of the filters, automation turned off: image

After turning automation on: no change. HOWEVER, Adjusting automation to be at the top: image

...something screwy is going on. I was going to show a screenshot of how just moments later the order in the modal gets screwed up but the side panel stays the same, and how that causes very screwy behaviour, but for some unknown reason now Automation is staying at the top and OHHHHH (epiphany, yes I am writing this as I experiment) - Automation has to be turned ON to edit the ordering, and as I usually sit in quest mode I had no quests that needed the automation - but going to dungeon tokens mode caused the issue: image

After swapping the bottom two (caught and automation) and then unswapping them so Automation was again second last: image

As you can see, something weird is going on.

I play on Chrome, and am not running with any other addons.

jensver commented 1 year ago

@Lokilotus have tried resetting the filters in stead of reordering? I had some strange behavior after the new catch filters update, but after resetting the filters it was fixed.

Farigh commented 1 year ago

@Lokilotus I did not manage to reproduce your behaviour. I tried many configurations :

I couldn't reproduce on any of those.

Did jensver's tip solve your issue ?