search

FarrOutLab / GWInferno

GWInferno: Gravitational-Wave Hierarchical Inference with NumPyro
MIT License
14 stars 5 forks source link

Combine-likelihoods #91

Closed bfarr closed 4 months ago

bfarr commented 4 months ago

This combines the log and non-log versions of the hierarchical likelihood and related functions.

I cleaned up documentation along the way where I could. It seems like the doc config was setup to expect numpydoc-style docstrings, but we've been using Google style. I've started moving to numpydoc-style on the functions I update.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 56.52174% with 20 lines in your changes missing coverage. Please review.

Project coverage is 37.02%. Comparing base (9dcc4e9) to head (26e0657).

Files Patch % Lines
gwinferno/pipeline/analysis.py 57.77% 19 Missing :warning:
gwinferno/pipeline/utils.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #91 +/- ## ========================================== + Coverage 36.52% 37.02% +0.50% ========================================== Files 33 33 Lines 2516 2490 -26 ========================================== + Hits 919 922 +3 + Misses 1597 1568 -29 ``` | [Flag](https://app.codecov.io/gh/FarrOutLab/GWInferno/pull/91/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FarrOutLab) | Coverage Δ | | |---|---|---| | [python3.10](https://app.codecov.io/gh/FarrOutLab/GWInferno/pull/91/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FarrOutLab) | `37.02% <56.52%> (+0.50%)` | :arrow_up: | | [python3.11](https://app.codecov.io/gh/FarrOutLab/GWInferno/pull/91/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FarrOutLab) | `37.02% <56.52%> (+0.50%)` | :arrow_up: | | [python3.9](https://app.codecov.io/gh/FarrOutLab/GWInferno/pull/91/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FarrOutLab) | `36.90% <56.52%> (+0.50%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FarrOutLab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bfarr commented 4 months ago

@jaxengodfrey, there's a TODO for you in the hierarchical likelihood related to the latent categorical treatment. Right now there's a standard sum() over a list comprehension, and I suggest a JAXified version. If that JAX version is correct, then I think what I do for the log=True option is correct.