search

FarseaSH / hugo-theme-moments

A Hugo theme designed for micro-blogging. 专为动态发布设计的Hugo主题
MIT License
132 stars 16 forks source link

feat: add local video support #10

Closed atompi closed 1 year ago

atompi commented 1 year ago

Support single video moment, like WeChat friend cycle. Just use the video key

FarseaSH commented 1 year ago

Hello atompi, thanks for your PR, I just went through the code. It is awesome. But I need to do some tests later before the code is merged.

Let me know if you have any other ideas.

Thanks again for your nice code!

FarseaSH commented 1 year ago

Hello, sorry for the delay. I checked the pr and it is great. There is only one thing I may change later. It is about how user embeds video in their moments. Currently in your code, {{ .Plain }} is the url for the video. I think it would be better to replace it with {{ .Params.video }} since {{ .Plain }} is mainly for the plain text.

Anyway, thanks so much for your pr. And if you have any thought on anything, don't hesitate to let me know.