search

FarseerTeam / Farseer

MIT License
2 stars 8 forks source link

Allow players to be updated with the REST api #8

Closed robertfmurdock closed 9 years ago

robertfmurdock commented 9 years ago

To support modifying player data, determine the ideal way to represent this via the server API and implement it.

As always, include meaningful tests that demonstrate this working in realistic conditions.

reebayroo commented 9 years ago

I finish the basic operations but I'd like a little bit of more information on 1-) Validation: What should be expected when email is not provided? Or when an update happens to break the uniqueness constraint of email. 2-) What should the api return with wrong ids on the parameter: An error message? A Json object?

robertfmurdock commented 9 years ago

My thoughts:

1) a person may need to change their email (or at least the primary email that might be used for pulling a gravatar or such), but for all other purposes of the system remain the same person. That said, if someone tries to use an email that's already in play, the API should probably reject that request explicitly. 2) Up to you. :-) All I ask is that a semantically useful message is included.